hmm I wish we could turn on bundle size bot for you - does this give any savings there?

Also, when this gets to a good place, could we split this up so we change each package one at a time?

One thing that makes this PR a little bit risky is the fact that the TypeScript compilation doesn't seem to complain about the node.js global appearing anywhere. This means there are no warnings if an undefined variable appears anywhere in code named global!

Also, when this gets to a good place, could we split this up so we change each package one at a time?

Yeah, I'll split it up because this PR has become huge!

So bundle.min.js is 83 bytes smaller vs before the changes to getGlobalObject in #5809 🤷‍♂️

One thing that makes this PR a little bit risky is the fact that the TypeScript compilation doesn't seem to complain about the node.js global appearing anywhere. This means there are no warnings if an undefined variable appears anywhere in code named global!

This feels fishy to me. It should be complaining... Is there a place where you see it in a package which doesn't have node types?

Is there a place where you see it in a package which doesn't have node types?

Just double checked and I can stick global anywhere in utils and there is no compilation error.

I suspect it's because @types/node is in the root node_modules and TypeScript just blindly loads everything in @types/* while following node module resolution.

Closing this in favour of multiple smaller PRs